search

redhat-et / rosa-apps

Gitops repo for ROSA application manifests
3 stars 7 forks source link

Change sigstore ctlog logPrefix to scaffolding #81

Closed mayaCostantini closed 1 year ago

mayaCostantini commented 1 year ago

This change might fix https://github.com/redhat-et/rosa-apps/issues/79 and was proposed by @sallyom in a previous discussion

sallyom commented 1 year ago

@mayaCostantini i was testing locally & I think my suggestion is not going to fix anything :( Can you remove the refs to our mid-stream images for fulcio, rekor, ctlog, trillian and bump the chart version to 0.6.22? We'll start from there to debug - hopefully that will get things working again & we'll update to our images 1 x 1.

mayaCostantini commented 1 year ago

Thanks for the suggestions, I pushed the changes you proposed

sallyom commented 1 year ago

@mayaCostantini it did afterall have to do w/ the scaffold/scaffolding prefix :facepalm: The release-name corresponds to the serviceaccount that runs the job-pods, and the serviceaccount for the rolebinding that allows anyuid for the job pods is hard-coded here and here. The release-name scaffold was creating serviceaccount scaffold-ctlog-createctconfig and scaffold-rekor-createtree so it didn't match the rolebinding. To fix this, can you update this release-name line to be scaffolding then all will be good.

sallyom commented 1 year ago

LGTM @Gregory-Pereira feel free to merge this please! We'll update to midstream images in a follow-up PR to match the helm chart version - first we must update those images.