Closed cescoffier closed 8 years ago
Hi @cescoffier . Thanks for the PR. I'll merge it soon.
@rafabene Let me know which approach you would prefer:
I can provide the second PR if you want.
My preference would be for the one with the simplest code. I don't want the attendees to think that it's too hard or too complex when they see the code. Do you mind to send the second PR so we could compare?
Thanks so much for your support.
No problm, will open another PR today or tomorrow morning.
Closing this since we decided to go with approach #2
This way is compliant with Vert.x.
Notice that I had to change the service interface to use an
Observable
as it's the only way to be async and non-blocking.Another approach (that does not require the service change) would be to use:
Both approaches have pros and cons.