search

redhat-helloworld-msa / aloha

Microservice using Vert.x
Apache License 2.0
11 stars 65 forks source link

Add fabric8io/docker-maven-plugin for creating the docker images #3

Closed rhuss closed 8 years ago

rhuss commented 8 years ago

The Docker build configuration creates the same Docker image as declared in Dockerfile. In addition it already adds the proper name for the image (not possible to specify in the Dockerfile) + it would be able to push it to a registry. Also it automatically updates to version upgrades, where a plain Dockerfile needs to be updared manually (there is an error btw in the current Dockerfile, it refers to the non-fat jar file in its ADD).

A sample run configuration is added which maps 8080 to a dynamic port and then assigns it to a Maven property ${aloha.port} which could be used in integration tests (along with ${docker.host.address} which is set to the IP of the Docker daemon). The section is optional and can be removed if not needed.

rafabene commented 8 years ago

@rhuss We added the Fabric8 plugin and Docker Maven plugin in the commit https://github.com/redhat-helloworld-msa/aloha/commit/c281a06bc6761d10579257354441116aaeefcfa6 - I believe that this makes this PR not necessary since we can now deploy the project to openshift.

rafabene commented 8 years ago

Closing this issue since docker plugin was added in https://github.com/redhat-helloworld-msa/aloha/commit/c281a06bc6761d10579257354441116aaeefcfa6