search

redhat-helloworld-msa / aloha

Microservice using Vert.x
Apache License 2.0
11 stars 65 forks source link

Fixed ZipKin integration #8

Closed jpkrohling closed 8 years ago

jpkrohling commented 8 years ago

The current aloha example uses a Servlet Filter, which is not effective on vert.x environments. This PR removes the filter and adds a similar capability through the usage of vert.x handlers. This is not the most appropriate solution, but should work for this example.

cc @objectiser , @cescoffier

cescoffier commented 8 years ago

Well done !

rafabene commented 8 years ago

Yeap. It seems that it's working now. Merged.

Thank you so much!!!! Well done!