redhat-helloworld-msa / helloworld-msa

Main repository with documentation and support files
Apache License 2.0
229 stars 158 forks source link

Fixed verification oc version for oc Origin #9

Closed alexeykazakov closed 8 years ago

alexeykazakov commented 8 years ago

oc version verification fails if oc Origin is used because it's v1.2.0

rafabene commented 8 years ago

Merged

rafabene commented 8 years ago

I have revert it because the following bug made the playbook crash: https://github.com/ansible/ansible/issues/17214

alexeykazakov commented 8 years ago

@rafabene you probably meant something else? Not https://github.com/ansible/ansible/issues/17214 right? Because: 1. that upstream issue is not a bug. 2. It's not related to this PR anyway. Or I missed something?

alexeykazakov commented 8 years ago

For clarification. My PR is using AND operator. Not OR. And of course this condition will fail if OR is used which is correct.

rafabene commented 8 years ago

Ok. I'll close the PR and try again.