search

redhat-imaging / imagefactory

imagefactory builds images for a variety of operating system/cloud combinations.
http:/imgfac.org
Apache License 2.0
153 stars 82 forks source link

RFE: imagefactory should take a custom vagrantfile and add it to the vagrantbox #361

Open LalatenduMohanty opened 8 years ago

LalatenduMohanty commented 8 years ago

Vagrant box is a compressed file format which includes an OS image , metadata file and a vagrantfile. There should be some way in which a custom vagrant file can be put in to a vagrant box. This will help to create a box with some configuration (which is difficult to put in to the ks file)

LalatenduMohanty commented 8 years ago

@imcleod I know there was some issue doing this. But it is keep coming back in our discussions. Can you please explain again the downside of having this feature?

hferentschik commented 8 years ago

I know there was some issue doing this. But it is keep coming back in our discussions. Can you please explain again the downside of having this feature?

+1 I would love to understand this as well. If we could utilizing the box'es default Vagrantfile we could improve the out of the box experience for a user a lot.

dustymabe commented 8 years ago

+1 - Discussed this with @imcleod. Basically there is one part of the Vagrantfile for vbox that needs to have a custom string in it for generating a mac address for the box. If this is no longer needed for vbox boxes then we could more easily implement this feature.

We should investigate to see if this is still needed for vbox and update this ticket.

hferentschik commented 8 years ago

Basically there is one part of the Vagrantfile for vbox that needs to have a custom string in it for generating a mac address for the box. If this is no longer needed for vbox boxes then we could more easily implement this feature.

Even in case this setting is still needed, could it not be merged into a custom Vagrantfile provided to ImageFactory.

We should investigate to see if this is still needed for vbox and update this ticket.

+1

LalatenduMohanty commented 8 years ago

We should investigate to see if this is still needed for vbox and update this ticket.

+1