Closed luisarizmendi closed 4 months ago
Couple of things:
Example: the summit_connect_2023 demo actually has both non-microshift and microshift images composed:
images_to_compose
contains all the images that will be composed. Versions 1-4 do not have microshift, while version 5 does.
The vaeiable rhsm_repos
is passed on to infra.osbuild, which enables the repos and runs the compose.
I do like the offline images for microshift piece, but can we toss that in its own playbook? "microshift-offline" or something like that, then individual demos/workshops can call on it when they want a totally offline microshift image.
Josh, thanks for the comments, here some clarifications to them:
This needs to be 2 PRs - One for changes specific to the gitops demo, the other for the microshift stuff
OK!
The microshift piece does not need to be done at a "global" level, the individual demos/workshops determine if microshift if desired.
That block is only executed if microshift_release is defined, so it already is in the individual demo/workshops where you determine if those steps will be done (in workshop extra-vars.yaml ). That's the same approach as when we use extra-vars.yaml to select the steps done from the "global" level playbook depending with workshop or a demo is (with variables workshop_or_demo and workshop_type). Maybe instead of using microshift_release we can add an additional variable such as enable_microshift: true
but I didn't include that one in order to minimize the number of variables (we still need to know the microshift release)
There are already demos/workshops with microshift, the enabling/disabling of repos/etc is handled by infra.osbuild, not by the playbooks or roles in this repo - we simply pass the additional information off
Yes, that's true but the thing with offline images is that you need to enable the OCP repos (to install an additional RPM package that is only there) in the host besides adding the external sources when building the image: https://access.redhat.com/documentation/en-us/red_hat_build_of_microshift/4.14/html/installing/microshift-embed-in-rpm-ostree-for-offline-use#microshift-embed-microshift-image-offline-deployment_microshift-embed-rpm-ostree-offline-use
I had to include a block in the Image Builder playbook to configure the Microshift repositories and the required files to be able to use Microshift offline container images as part of the generated RHDE image.
In the PR you will find many other changes but those are only related to the gitops-demo, the main block in compose-images.yaml is: