redhat-na-ssa / demo-ai-gitops-catalog

A catalog for all things GitOps for AI on OpenShift
MIT License
10 stars 12 forks source link

Gpu instance refactor #62

Closed strangiato closed 2 months ago

strangiato commented 2 months ago

This PR refactors the GPU instance examples using components.

The idea for components is that each piece is an independent, reusable chunk of configuration that is focused on one specific thing.

Components can be combined and used in multiple overlays with limited overlap.

This update also moves the monitoring-dashboard to purely kustomize with no need for a job. The console-plugin also now references the chart with kustomize and the only thing happening in the job is enabling the console plugin.

The overlays should not change so any references to those should not be impacted.

strangiato commented 2 months ago

Something else that is probably important for this update, is that the console-plugin component does require that the --enable-helm flag is configured for argocd.

See this for enabling that option:

https://github.com/redhat-cop/gitops-catalog/tree/main/openshift-gitops-operator/instance/components/kustomize-build-enable-helm

codekow commented 2 months ago

Good enough :+1: