redhat-openshift-ecosystem / openshift-preflight

Operator and container preflight certification tests
Apache License 2.0
60 stars 65 forks source link

updating documentation URLs #1120

Closed aksaswadkar closed 10 months ago

aksaswadkar commented 10 months ago

Partner certification documentation has been updated to use the current year as the version number. This simplifies and creates annual static links.

I believe this also solves the https://github.com/redhat-openshift-ecosystem/openshift-preflight/issues/1083

openshift-ci[bot] commented 10 months ago

Hi @aksaswadkar. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dcibot commented 10 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1120:

acornett21 commented 10 months ago

@aksaswadkar Are you saying that the docs folks have changed their URL scheme, and it will change based on the year now? Do you know if they'll ever offer a /latest route? Also, Can you rebase off of main? That will fix the test failure. Thanks for the PR.

aksaswadkar commented 10 months ago

Hi @acornett21 Yes, the docs URLs are based on the year now. Not sure about the /latest though.

dcibot commented 10 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1120:

acornett21 commented 10 months ago

/ok-to-test

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, aksaswadkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/OWNERS)~~ [acornett21] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment