handling pyxis version check errors to display preflight release url

redhat-openshift-ecosystem / openshift-preflight

Operator and container preflight certification tests

Apache License 2.0

58 stars 66 forks source link

handling pyxis version check errors to display preflight release url #1141

Closed acornett21 closed 1 month ago

acornett21 commented 2 months ago

Relates: ##1135
Handling the two possible 400 series error messages.
Displaying the latest preflight release URL to the user.

Sample Pyxis Responses: Screenshot from 2024-03-12 12-39-13

openshift-ci[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1141:

SUCCESS https://www.distributed-ci.io/jobs/8e6747e8-7dab-4065-b857-b5be5cd70b12/jobStates

acornett21 commented 2 months ago

/test 4.15-e2e

acornett21 commented 2 months ago

/test 4.12-e2e

acornett21 commented 2 months ago

/test all

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1141:

SUCCESS https://www.distributed-ci.io/jobs/ff646d9b-bfe1-483a-b2d4-aa39ac10d10d/jobStates

acornett21 commented 2 months ago

@komish @bcrochet I'm not really sure what to do with this PR. IMO using string(body) everywhere is the clearest path forward, since the intent of the type being used is in the code, trying to add another variable intrudes confusion of value/type of any given line of code that needs both the byte value and the string value.

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1141:

SUCCESS https://www.distributed-ci.io/jobs/c7b237a2-c45d-458e-90a5-58d9604a372a/jobStates

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1141:

SUCCESS https://www.distributed-ci.io/jobs/33c2238b-8f21-41a0-bfc6-811b76eeb7c0/jobStates

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/OWNERS)~~ [acornett21,bcrochet,komish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment