reordering submit flow to create test results as first action

redhat-openshift-ecosystem / openshift-preflight

Operator and container preflight certification tests

Apache License 2.0

58 stars 66 forks source link

reordering submit flow to create test results as first action #1151

Closed acornett21 closed 2 months ago

acornett21 commented 2 months ago

Reordering submit flow to create test results early, then update them in the case where we have successfully created an image to link to the results.
We need not worry about re-try, or re-run (of preflight like in other API calls) or any of the other things we worry about for other pyxis routes, since pyxis/connect will just ignore (not show?) any results not linked to any images.
createTestResults was modified to account for both PATCH/POST, since there would be less duplicate code, if others are happier with two distinct methods, I'm happy to refactor that way as well.
JIRA: EET-3965

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1151:

FAILURE https://www.distributed-ci.io/jobs/a06095f0-245d-43b3-a15d-a8b53ad5758e/jobStates

acornett21 commented 2 months ago

/test 4.12-e2e

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1151:

FAILURE https://www.distributed-ci.io/jobs/4fead1c4-f708-4e0c-857e-a62cd8674df3/jobStates

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1151:

FAILURE https://www.distributed-ci.io/jobs/e180ef9a-9980-4d28-a122-8f9681f733a3/jobStates

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1151:

SUCCESS https://www.distributed-ci.io/jobs/e05296e1-8a13-437c-a53c-40a11c6eda2d/jobStates

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, Allda, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/OWNERS)~~ [acornett21,bcrochet,komish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment