search

redhat-openshift-ecosystem / openshift-preflight

Operator and container preflight certification tests
Apache License 2.0
58 stars 66 forks source link

fix(engine): close file when untar #1153

Closed nikpivkin closed 1 month ago

openshift-ci[bot] commented 2 months ago

Hi @nikpivkin. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1153:

acornett21 commented 2 months ago

/ok-to-test

bcrochet commented 2 months ago

@nikpivkin Please add a test for this.

nikpivkin commented 2 months ago

@bcrochet What's the test supposed to check? I just added file closing.

bcrochet commented 1 month ago

@bcrochet What's the test supposed to check? I just added file closing.

Fair enough. Thanks for the submission.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, nikpivkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/OWNERS)~~ [acornett21,bcrochet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment