search

redhat-openshift-ecosystem / openshift-preflight

Operator and container preflight certification tests
Apache License 2.0
58 stars 66 forks source link

adding a call to controller-runtimes SetLogger and io.Discard #1160

Closed acornett21 closed 2 months ago

acornett21 commented 2 months ago
dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1160:

komish commented 2 months ago
  1. Is this a result of a controller-runtime version bump, or have these log lines been there for a while?
  2. If this is new, should this not be a bug filed against controller-runtime?
  3. Should this be run closer to where the problem is? E.g. DeployableByOLM-related code?
acornett21 commented 2 months ago
  1. Is this a result of a controller-runtime version bump, or have these log lines been there for a while?
  2. If this is new, should this not be a bug filed against controller-runtime?
  3. Should this be run closer to where the problem is? E.g. DeployableByOLM-related code?
  1. This has been in controller-runtime since 0.15.0, and I've noticed it off/on since then, but since I'm usually running in trace I never understood why it would sometimes happen, and others not.
  2. No, this isn't a bug in controller runtime. It's just a warning to remind users of the library that 'hey you haven't called the logger'.
  3. I believe this is where this needs to be, since this is part of the init chain and only have 30seconds before the warning is thrown, at least that's how I read the code. Most other projects have this is root or main
dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1160:

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/OWNERS)~~ [acornett21,bcrochet,komish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment