Ensure files and links have missing parent dirs created. Support hard links.

redhat-openshift-ecosystem / openshift-preflight

Operator and container preflight certification tests

Apache License 2.0

60 stars 65 forks source link

Ensure files and links have missing parent dirs created. Support hard links. #1179

Closed komish closed 4 months ago

komish commented 5 months ago

This PR addresses two issues:

When extracting the image tarball to the filesystem, we would fail if a file (e.g. etc/foo.conf) was created before its parent directory (e.g. etc/). This has been fairly uncommon, but for cases where this happens, we'll now create the directory if it's missing.
We did not handle hard links before, and now we do. We also would fail to handle all links properly, in that links pointing to a path relative to the link would not be resolved properly. This PR properly resolves the link path and the original file's path relative to the link path if it's a relative reference (e.g. ../). All links are still executed using full paths.

dcibot commented 5 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1179:

SUCCESS https://www.distributed-ci.io/jobs/f72abdb7-d438-46cf-bc21-405ceeda8701/jobStates

coveralls commented 5 months ago

coverage: 84.593% (-0.2%) from 84.79% when pulling 8ed7767fde758edb8b13e08d0c2e5e8f78bfcdd6 on komish:fix-untar-link-and-file-res into 282a25bdfdc9d9759015bbfa3d1a29b569825d1a on redhat-openshift-ecosystem:main.

dcibot commented 5 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1179:

SUCCESS https://www.distributed-ci.io/jobs/91b60520-409b-4c2d-91d2-7afc4fda2bb4/jobStates

coveralls commented 5 months ago

coverage: 84.352% (-0.4%) from 84.79% when pulling d4dbf03884769b61c8faa89c494575b7d1919893 on komish:fix-untar-link-and-file-res into 282a25bdfdc9d9759015bbfa3d1a29b569825d1a on redhat-openshift-ecosystem:main.

dcibot commented 5 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1179:

FAILURE https://www.distributed-ci.io/jobs/33b0c48f-7634-4888-a4bf-764460bcb50d/jobStates

ramperher commented 5 months ago

from change #1179:

FAILURE https://www.distributed-ci.io/jobs/33b0c48f-7634-4888-a4bf-764460bcb50d/jobStates

Hi, fix is coming for the issue that appeared in the last DCI job, if launching a new job and failing again here, you can add the following to your PR description to launch the fix (saying this because I don't have permissions to edit the PR description in this repo):

build-depends: 31882

Thanks!

dcibot commented 4 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1179:

SUCCESS https://www.distributed-ci.io/jobs/2c6fed67-adac-4662-b877-598311cb1052/jobStates

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/OWNERS)~~ [acornett21,bcrochet,komish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment