Refactor commands to take a viper instance

redhat-openshift-ecosystem / openshift-preflight

Operator and container preflight certification tests

Apache License 2.0

60 stars 65 forks source link

Refactor commands to take a viper instance #1200

Open bcrochet opened 2 months ago

bcrochet commented 2 months ago

Instead of relying on a global instance, the commands should instead have viper injected. This will make testing easier.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/OWNERS)~~ [bcrochet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

bcrochet commented 2 months ago

Replaces #958

dcibot commented 2 months ago

from change https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/1200:

SUCCESS https://www.distributed-ci.io/jobs/ffbef3f1-9b0a-4965-9beb-00c6abca8ef0/jobStates

openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.