search

redhat-openstack / ansible-nfv

Ansible NFV repository holds various playbooks for installation, configuration, tuning, testing and day to day tasks related to NFV and Openstack.
Apache License 2.0
22 stars 20 forks source link

Added validate_certs to all post_install/os-functions #3

Closed jbadiapa closed 4 years ago

jbadiapa commented 4 years ago

Using the test with a tripleo-quickstart deployment, I got the error like "keystoneauth1.exceptions.discovery.DiscoveryFailure: Could not find versioned identity endpoints when attempting to authenticate. Please check that your auth_url is correct. SSL exception connecting to https://10.0.0.5:13000: HTTPSConnectionPool(host=10.0.0.5, port=13000): Max retries exceeded with url: / (Caused by SSLError(SSLError(1, [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:897)),))"

So adding the validate_certs=False on the parameters bypass the error

MaxBab commented 4 years ago

Hi Juan,

Thank you for your contribution. We are accepting the patches via the gerrithub. The contribution instructions provided here: https://github.com/redhat-openstack/ansible-nfv/blob/master/contribution.md

Also, we are align to the default param values of the module. The default params are: validate_certs: false

In case you would like us to take case of the submission via the gerrithub, let me know.

MaxBab commented 4 years ago

Better even to omit the parameter value in case it is not specified. In that case, it will automatically take the module default and will keep to it even if it will change.

validate_certs: "{{ validate_certs | default(omit) }}"

jbadiapa commented 4 years ago

Oh, sorry I didnt realized about the .gitreview file.