search

redhat-openstack / ansible-role-tripleo-image-build

An ansible role used to create and publish quickstart built images
Apache License 2.0
5 stars 3 forks source link

shell blocks #24

Open halcyondude opened 8 years ago

halcyondude commented 8 years ago

For the many shell blocks in the build role, there is a mixture of > and | style shell blocks.

In this review: https://review.gerrithub.io/#/c/283664 Atilla recommended > instead of | for good reasons.

https://paste.fedoraproject.org/390295/46833886/

this issue is to track making the shell blocks consistent.

halcyondude commented 8 years ago

Many of these have been fixed, there are a few more. The ones that use shell: >, and also have a > i/o redirect seem to be problematic. will address as a back burner item at low priority unless someone wants to take a crack at it.