search

redhat-openstack / ansible-role-tripleo-image-build

An ansible role used to create and publish quickstart built images
Apache License 2.0
5 stars 3 forks source link

DIB elements passed to disk-image-create are hard coded #9

Closed halcyondude closed 8 years ago

halcyondude commented 8 years ago

In tasks/dib_build.yml, when we call disk-image-create, the elements for the IPA and overcloud are hard coded. they should be a list defined in yaml, bonded to a variable that can be over-ridden.

This will help with making this more declarative, and for building non centos7 / non-RDO, is needed to keep things clean (and to keep keyboards from catching fire @weshayutin @trown)

This issue tracks migrating the hard coded lists (overcloud and IPA) --> variables.

Here's an example of where we build IPA:

shell: | source {{ artib_working_dir }}/dib-optional-env-inject.sh disk-image-create \ -a amd64 \ -o {{ artib_working_dir }}/ironic-python-agent \ centos7 \ dhcp-all-interfaces \ dynamic-login \ selinux-permissive \ pip-and-virtualenv-override \ ironic-agent \ -p python-hardware-detect \ --min-tmpfs 5 2>&1 | tee {{ artib_working_dir }}/dib-agent-ramdisk.log environment: DIB_LOCAL_IMAGE: "{{ artib_working_dir }}/minimal-base.qcow2" DIB_DEFAULT_INSTALLTYPE: package ELEMENTS_PATH: "{{ artib_dib_elements_path }}" async: 3600 poll: 0 register: done_build_ironic

halcyondude commented 8 years ago

WIP: merely a prototype at this point. https://review.gerrithub.io/#/c/273340/

halcyondude commented 8 years ago

Work is currently underway by @trown to replace the thin (existing) jinja wrapper around DIB with an invocation of the wrapper in tripleo-common. this is happening here: https://review.gerrithub.io/#/c/274691/ to address https://github.com/redhat-openstack/ansible-role-tripleo-image-build/issues/17. Sequencing the fix for this to land just after that work, as it involves changing the same bits/files.

halcyondude commented 8 years ago

tripleo-common mechanism is now in place.

WIP: https://review.gerrithub.io/#/c/276629/

halcyondude commented 8 years ago

this issue has been resolved some time ago. We are no longer driven with hard coded dib elements. performing issue housecleaning.