search

redhat-openstack / easyfix

6 stars 5 forks source link

Remove **Requires: python-setuptools** from spec file #10

Closed chkumar246 closed 7 years ago

chkumar246 commented 7 years ago

python-setuptools is required during %build step during rpm package building process. So, it should be used as BuilRequires: python-setuptools in spec file. In lots of RDO packages, python-setuptools is used as a Requires that's needs to be remove.

What to improve:

  1. Clone os-apply-config spec file git clone https://github.com/rdo-packages/os-apply-config-distgit
  2. Go to os-apply-config-distgit and open os-apply-config.spec in editor.
  3. You can find Requires: python-setuptools in spec file.
  4. We need to remove this line "Requires: python-setuptools" from spec file.
  5. Once done! Make changes, add and commit it and send a Gerrit Review.
  6. Please cross checklist before sending Gerrit Review.

Example Spec containing the above fix:

  1. tempest-horizon

Below is the list of packages which need same fixes:

Mentors

  1. chandankumar
snecklifter commented 7 years ago

https://review.rdoproject.org/r/7981 https://review.rdoproject.org/r/7982 https://review.rdoproject.org/r/7983 <--- os-cloud-config abandoned as retired upstream @chkumar246 https://review.rdoproject.org/r/7984 https://review.rdoproject.org/r/7985 https://review.rdoproject.org/r/7986

snecklifter commented 7 years ago

I suspect there are more, will check before closing this.

snecklifter commented 7 years ago

Have checked, no more occurrences.

apevec commented 6 years ago

Just a note that setuptools could be a hidden runtime dep, like we discovered in Packstack: https://review.rdoproject.org/r/9090