Closed chkumar246 closed 6 years ago
test builds failed for keystoneclient & tripleo-validations, but mistrial-dashboard worked:
https://review.rdoproject.org/r/#/c/7742/ https://review.rdoproject.org/r/#/c/7747/
IMO, coverage should not be removed from horizon spec file. Tests are not run there during package build (different issue), but if you're running the tests, coverage gives a bit more detail.
@chkumar246 can you discuss with other cores please as I'm just doing the work. Cheers.
My opinion on this is:
Agreed with amoralej's comment. If coverage is not being actively used in %check, it doesn't make any sense to keep it as a build requirement (because it's not).
python-coverage is used to generate test coverage report for any project. During RPM building process, we run tests only and donot generate coverage report. In RDO Packages, at most places python-coverage is used as BuildRequires or Requires.
What to improve:
Example Spec containing the above fix:
Below is the list of packages which need same fixes:
Mentors