redhat-openstack / easyfix

6 stars 5 forks source link

PYTHONPATH cleanup #18

Closed yazug closed 7 years ago

yazug commented 7 years ago

as identified by chandankumar

jschlueter: export pythonpath no longer needed python-oslo-context .spec file still has export PYTHONPATH in the doc generation section. there may be more packages with similar packaging differences ## What to improve: 1. Clone tripleo-validations-distgit spec file git clone https://github.com/rdo-packages/glance-distgit 2. Go to glance-distgit and open openstack-glance.spec in editor. 3. You can find PYTHONPATH in the build section of the in spec file. 4. We need to remove those lines from spec file (including relevant comments to PYTHONPATH). 5. Once done! Make changes, add and commit it and send a Gerrit Review. 6. Please cross [checklist](https://github.com/redhat-openstack/easyfix#checklist-for-sending-your-first-rdo-gerrit-review) before sending Gerrit Review. ## Below is the list of packages which need same fixes: - [x] [barbicanclient](https://github.com/rdo-packages/barbicanclient-distgit) - [X] [ceilometerclient](https://github.com/rdo-packages/ceilometerclient-distgit) - [x] [cloudkitty](https://github.com/rdo-packages/cloudkitty-distgit) - [x] [django_openstack_auth](https://github.com/rdo-packages/django_openstack_auth-distgit) - [x] [glanceclient](https://github.com/rdo-packages/glanceclient-distgit) - [x] [glance](https://github.com/rdo-packages/glance-distgit) - [x] [gnocchiclient](https://github.com/rdo-packages/gnocchiclient-distgit) - [x] [keystone](https://github.com/rdo-packages/keystone-distgit) - [x] [manila](https://github.com/rdo-packages/manila-distgit) - [x] [neutronclient](https://github.com/rdo-packages/neutronclient-distgit) - [x] [nova](https://github.com/rdo-packages/nova-distgit) - [x] [oslo-context](https://github.com/rdo-packages/oslo-context-distgit) - [x] [oslo-vmware](https://github.com/rdo-packages/oslo-vmware-distgit) - [x] [os-testr](https://github.com/rdo-packages/os-testr-distgit) - [x] [sahara](https://github.com/rdo-packages/sahara-distgit) - [X] [swiftclient](https://github.com/rdo-packages/swiftclient-distgit) ## Mentors 1. jschlueter (yazug)
OGtrilliams commented 7 years ago

glance-distgit - https://review.rdoproject.org/r/8094 glanceclient-distgit - https://review.rdoproject.org/r/8097 cloudkitty-distgit - https://review.rdoproject.org/r/8095 barbicanclient-distgit - https://review.rdoproject.org/r/8096

snecklifter commented 7 years ago

@yazug @chkumar246 @OGtrilliams the remaining patches are done

snecklifter commented 7 years ago

All patches are merged except for some which specifically require PYTHONPATH (Gnocchi).

yazug commented 7 years ago

https://review.rdoproject.org/r/#/q/branch:rpm-master+topic:easyfix/18+status:open still shows 3 open

snecklifter commented 7 years ago

@yazug thanks, the glance one needs abandoning as the fix already went in, the other two I have updated.

snecklifter commented 7 years ago

Just waiting on +W at https://review.rdoproject.org/r/#/c/8095/

snecklifter commented 7 years ago

Hooray. @yazug happy to close this one?

yazug commented 7 years ago

looks good and thanks!