search

redhat-openstack / infrared

Plugin based framework that aims to provide an easy-to-use CLI for Ansible based projects
https://infrared.readthedocs.io/en/latest/index.html
Apache License 2.0
100 stars 96 forks source link

Circleci #350

Closed greg-hellings closed 5 years ago

greg-hellings commented 5 years ago

Adds support for CI builds in Circle CI to help improve future testing.

Also fixes a syntax error in the docs, allowing them to build and pass testing. Once this is merged, CI building can be enabled through the Cirlce CI website by anyone with admin rights to this repository.

MaxBab commented 5 years ago

Hello, @greg-hellings,

All infrared patches submitted from the gerrithub system. Any new patch triggers test jobs which execute linting, pep8, py27, etc... For the plugins changes, functional tests are executed. A real osp environment installed and tested. So there is no need to add such builds.

Thanks.

greg-hellings commented 5 years ago

Hi @MaxBab, I'm not completely sure what you're saying - are you saying that you don't accept PRs through GitHub? I had to use Gerrit once upon a time internally (thankfully those days are long past) but I'm completely unfamiliar with Gerrithub.

Also, are the results of tests visible anywhere here in the upstream world? It doesn't appear that all tox environments are tested as there are failures in the existing tests (try running "tox -e docs" on the current git master). Also, there used to be tests for Python 3, which is really my interest, but those tests are no longer executing. There are a few issues with Python 3 compatibility that I would love to see working properly.

MaxBab commented 5 years ago

Yes, @greg-hellings, we are working with the gerrithub system and all the patches submitted there. The link to the project on the gerrithub system: https://review.gerrithub.io/q/project:+redhat-openstack/infrared

When the tests pass, the "Verified" label in the gerrithub system is set to +1. But the logs of the tests could not be seen as the tests are running on the internal redhat servers.

We will check the failures of the tox. Regarding the python3 compatibility, the core maintainers of infrared currently working on this.