redhat-openstack / infrared

Plugin based framework that aims to provide an easy-to-use CLI for Ansible based projects
https://infrared.readthedocs.io/en/latest/index.html
Apache License 2.0
100 stars 96 forks source link

Unable to register nodes to overcloud #352

Closed valleedelisle closed 5 years ago

valleedelisle commented 5 years ago

This patch solves the issue

diff --git a/infrared/common/roles/cdn_registery/tasks/main.yml b/infrared/common/roles/cdn_registery/tasks/main.yml
index 4c8d8f14..5b9f84af 100644
--- a/infrared/common/roles/cdn_registery/tasks/main.yml
+++ b/infrared/common/roles/cdn_registery/tasks/main.yml
@@ -6,6 +6,7 @@

 - name: unregister from all repos
   command: subscription-manager repos --disable=*
+  ignore_errors: yes

 - name: register to openstack repos
   vars:
diff --git a/infrared/common/roles/cdn_registery/tasks/register_cdn.yml b/infrared/common/roles/cdn_registery/tasks/register_cdn.yml
index 09981acf..1f6ba9b3 100644
--- a/infrared/common/roles/cdn_registery/tasks/register_cdn.yml
+++ b/infrared/common/roles/cdn_registery/tasks/register_cdn.yml
@@ -8,6 +8,7 @@
 - name: Check if Satellite server
   shell: |
     curl -L -k -s -D - -o /dev/null https://{{ cdn_creds.server_hostname }}/pub/katello-ca-consumer-latest.noarch.rpm | grep "200 OK"
+  ignore_errors: yes
   register: satellite_detected

 - block:
valleedelisle commented 5 years ago

These are the errors we're preventing.

1- CDN is not a satellite server

TASK [cdn_registery : Check if Satellite server] *******************************************************************************************************************************************************************************************************************************************************************************************************************************************
 [WARNING]: Consider using get_url or uri module rather than running curl

fatal: [undercloud-0]: FAILED! => {"changed": true, "cmd": "curl -L -k -s -D - -o /dev/null https://subscription.rhsm.redhat.com/pub/katello-ca-consumer-latest.noarch.rpm | grep \"200 OK\"", "delta": "0:00:01.472256", "end": "2019-02-28 11:16:09.875594", "msg": "non-zero return code", "rc": 1, "start": "2019-02-28 11:16:08.403338", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
...ignoring

2- From this bug, this is an expected behavior

TASK [cdn_registery : unregister from all repos] ********************************************************************************************************************************************
fatal: [undercloud-0]: FAILED! => {"changed": true, "cmd": ["subscription-manager", "repos", "--disable=*"], "delta": "0:00:13.514245", "end": "2019-02-28 10:54:25.029469", "msg": "non-zero return code", "rc": 1, "start": "2019-02-28 10:54:11.515224", "stderr": "", "stderr_lines": [], "stdout": "Error: '*' does not match a valid repository ID. Use \"subscription-manager repos --list\" to see valid repositories.", "stdout_lines": ["Error: '*' does not match a valid repository ID. Use \"subscription-manager repos --list\" to see valid repositories."]}
...ignoring