undercloud CDN registry issue

mrVectorz commented 5 years ago

Description

Using the "tripleo-undercloud" plugin with "--cdn" it forces to use a server_hostname.

Command used:

infrared tripleo-undercloud --version 13   --registry-namespace rhosp13   --images-task=rpm   --cdn ~/Work/randoms/ir_templates/rh-subscription.yaml --build ga --ssl no

The "rh-subscription.yaml" file:

state: present
autosubscribe: true
activationkey: YOUR_ACTIVATION_KEY
org_id: 0123456

Which does not require a "server_hostname" when using org+activation_key.

Solution

Need to change the conditionals on "Check if Satellite server" and the block right after it. What I did to fix it (just changed the two "when"):

- name: Check if Satellite server
  uri:
    url: "https://{{ cdn_creds.server_hostname }}/katello/api/ping"
    validate_certs: no
    status_code: 200, 404
  register: _sat6_check
  when: cdn_creds.server_hostname is defined

- block:
    - name: Download katello-ca-consumer-latest.noarch.rpm
      get_url:
          url: "https://{{ cdn_creds.server_hostname }}/pub/katello-ca-consumer-latest.noarch.rpm"
          dest: "/tmp/katello-ca-consumer-latest.noarch.rpm"
          force: yes
          validate_certs: no

    - name: Install katello-ca-consumer-latest.noarch.rpm
      package:
          name: /tmp/katello-ca-consumer-latest.noarch.rpm
          state: present
  when: cdn_creds.server_hostname is defined and _sat6_check['status'] == 200

ERROR:

https://github.com/redhat-openstack/infrared/blob/master/infrared/common/roles/cdn_registery/tasks/register_cdn.yml#L13


TASK [cdn_registery : Check if Satellite server] ******************************************************************************************************************************************************************
fatal: [undercloud-0]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'server_hostname'\n\nThe error appears to have been in '/home/mmethot/.venv_infrared/lib/python2.7/site-packages/infrared/common/roles/cdn_registery/tasks/register_cdn.yml': line 8, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Check if Satellite server\n  ^ here\n"}

NO MORE HOSTS LEFT **** to retry, use: --limit @/home/mmethot/.infrared/plugins/tripleo-undercloud/main.retry

PLAY RECAP **** hypervisor : ok=6 changed=3 unreachable=0 failed=0
localhost : ok=3 changed=2 unreachable=0 failed=0
undercloud-0 : ok=19 changed=10 unreachable=0 failed=1

ERROR Playbook "/home/mmethot/.infrared/plugins/tripleo-undercloud/main.yml" failed!

mrVectorz commented 5 years ago

Fix is in this review: https://review.gerrithub.io/c/redhat-openstack/infrared/+/448592

avishaymahluf commented 5 years ago

@mrVectorz I merged your patch. Thank you for your contribution.

redhat-openstack / infrared