redhat-openstack / openshift-on-openstack

A place to write templates, docs etc. for deploying OpenShift on OpenStack.
Apache License 2.0
136 stars 87 forks source link

Allow the user to select the OSP version on which the stack will run #313

Closed markllama closed 7 years ago

markllama commented 7 years ago

The bastion host must communicate with the OSP service and gather host information from the other instances. It uses the os-collect-config RPM to configure the communications and collect information.

The location of this package depends on the version of OSP in use. The OSP RPM repo names change with the OSP version.

This patch allows the caller to set the OSP version so that the templates can install and configure the correct version of the os-collect-config package and prepare for operation.

jprovaznik commented 7 years ago

LGTM, Mark reported that testing this on OSP 8 and 10 was OK, merging this as there is nobody else ATM.

jprovaznik commented 7 years ago

@markllama it would be also nice to add a note into README about posibility to set OCP version (in a followup patch).