search

redhat-openstack / puppet-pacemaker

Puppet modules to manage pacemaker with corosync
9 stars 25 forks source link

Consistent naming of fence agent manifests #49

Closed jistr closed 9 years ago

jistr commented 9 years ago

Use pacemaker::stonith:: for the original fence agent manifests, and use pacemaker::stonith::fence_ for the autogenerated manifests.

It's not sure yet whether e.g. TripleO will use the autogenerated fencing manifests, or if we only should use autogeneration as the first step and start editing the fence agents manually to allow additional operations besides creating the fencing resources (e.g. like in xvm's case - writing the key file and configuring the firewall).

Anyway it seems like a good idea to have consistent naming, which could be useful when passing parameters around in a generic fashion. I'm not replacing the fence_xvm manifest with the autogenerated variant yet, to allow for a deprecation period.

jguiditta commented 9 years ago

+1 LGTM, @cwolferh ?

cwolferh commented 9 years ago

Good idea.