Need some basic lint CI

redhat-openstack / tripleo-quickstart

Ansible roles for setting up TripleO virtual environments and building images

16 stars 15 forks source link

Need some basic lint CI #16

Closed trown closed 8 years ago

trown commented 8 years ago

Things like line length, but could also include some ansible style guidelines.

larsks commented 8 years ago

Line length will be a tricky one.

URLs can be long (http://trunk.rdoproject.org/centos7-liberty/ce/30/ce30250c9e9858aeddb0f65583ceaa8a49fe62b4_a2b13371/diskimage-builder-1.11.1-0.20160217003244.352e58c.el7.centos.noarch.rpm)

Fully qualified python module names can be long (nova.virt.baremetal.virtual_power_driver.VirtualPowerManager).

We would need a way to exempt files or specific lines (comment on preceding line?) from the linting.

trown commented 8 years ago

Covered by https://bugs.launchpad.net/tripleo-quickstart/+bug/1571047 for now, we can open more launchpad bugs for future lint-style scripts.