redhat-openstack / tripleo-quickstart

Ansible roles for setting up TripleO virtual environments and building images
16 stars 15 forks source link

Use in-tree scripts in the jenkins builders #58

Closed trown closed 8 years ago

trown commented 8 years ago

Currently, the shell script that is run for the CI jobs is defined in the jenkins/jobs/builders.yml. This makes it difficult to change what is run in CI, since it requires pushing the jenkins change to see the result. The only way to test in advance what a change to the shell script will look like is to manually create POC jobs.

Alternatively, we can create a top level ci-scripts directory with the following scripts:

Then the builders would be simplified to:

bash get-node.sh
bash quickstart.sh <args for specific builder> $VIRTHOST
bash collect-logs.sh
bash return-node.sh

This would then allow us to easily iterate on simplifying the process to get and return a node to CI. It would be good to move the log collection from the khaleesi tree to its own ansible role, either in the oooq tree, or its own ansible-role-tripleo-log-collect repo.

trown commented 8 years ago

resolved by https://github.com/redhat-openstack/tripleo-quickstart/commit/389d2e9af6eb3fa00fc5096246de33b71279e3a5