redhat-partner-solutions / crucible

Apache License 2.0
36 stars 59 forks source link

Install manual binaries in /usr/local/bin #114

Closed thekad closed 2 years ago

thekad commented 2 years ago

One of the requirements says to install the openshift-clients package, which provides /usr/bin/{kubectl,oc}. Then when populating the registry we download the binaries according to the version to be installed, then overwrite them on top of the ones in /usr/bin. It's probably better to keep the integrity of the RPM DB and install them to /usr/local/bin instead.

nocturnalastro commented 2 years ago

I agree. Another way we could do it just check if they exist already and skip the steps of getting them.

thekad commented 2 years ago

Well, if you download a new version of OCP then you'd preferably want the clients matching the version, so downloading seems fine to me.