Closed nocturnalastro closed 1 year ago
@nocturnalastro Is this PR ready for review? Given the size of this PR can we set a time to go through this together?
@arjuhe I think it's ready now, I though it was a draft previously but I guess not. We can go through it together sounds like a good idea.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
dci-check-change : SUCCESS tested on libvirt:assisted
assisted -> success: https://www.distributed-ci.io/jobs/f7afdfb3-e1b5-462d-905d-9060ce23c033/jobStates
basic_example -> success: https://www.distributed-ci.io/jobs/f330f65c-061b-45c6-9ced-b5fb994979cf/jobStates
So this run verified that this PR still works when doing a regular assisted install. For ABI, our inventories need to be updated in our CI system to support a network_config. I will work on that next week.
Can you rebase this with 359432add22eb4cd9acf032096b898df39855476 included? I am having trouble testing it without that commit.
Thanks
Starting dci-check-change job.
@p3ck it should be up to date now :)
This almost works: the workflow leaves you with a working cluster with one exception: the certificates generated by the ABI method are not trusted by the bastion host, you get a warning about it (e.g. https://www.distributed-ci.io/jobs/3ec463e1-a08c-4055-a2f0-62efc7107043/jobStates?sort=date&task=3eba8dce-f9f2-4b89-9627-dd18bedbb90b )
I am not sure what difference is from OnPrem to ABI here is re: certificates, I think OnPrem incidentally works around the issue by providing the already trusted certificate chain used to configure the AI service and registry on bastion.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
@thekad
That's interesting because that task shouldn't run for the agent based installer. Its the onprem assisted installer specific file See here.
The agent based installer already has the login token in the kubeconfig so there is no need to add it. Interesting that it fails though. I'll try it manually and reach out to the product team about it.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
ACK, This one is going to take a couple of days.