redhat-partner-solutions / crucible

Apache License 2.0
35 stars 59 forks source link

Have sushy tools installed in a virtual env #192

Closed thekad closed 1 year ago

thekad commented 1 year ago

Currently, sushy tools is installed in the system-wide python path, this causes issues with e.g. newer versions of libraries in the sushy releases, and overwriting RPM files with PIP files. Also adjusting the systemd service file to use the virtual environment.

thekad commented 1 year ago

cc @p3ck

nocturnalastro commented 1 year ago

Thanks for this :) I tried something similar the other week by hand and had an issue with missing python bindings for libvirt, I must have missed something. Code looks fine for a quicky 5pm glance. I'll test this one Tomorrow morning :).

nocturnalastro commented 1 year ago

I hit this error sushy-emulator[900973]: [2022-11-25 05:32:14,748] ERROR in main: libvirt driver not loaded I think the python package for the libvirt bindings isn't in the virtual env

nocturnalastro commented 1 year ago

A quick attempt at adding libvirt-python failed.

thekad commented 1 year ago

Hmmmm, my virtualenv must've been polluted, let me make an attempt from zero and will try to figure it out

thekad commented 1 year ago

@nocturnalastro it wasn't my virtualenv, rather my machine had libvirt-devel already installed, can you take a look please ?