search

redhat-partner-solutions / crucible

Apache License 2.0
35 stars 59 forks source link

Don't change kvm_node_name #198

Closed p3ck closed 1 year ago

p3ck commented 1 year ago

Use the name given.

In our Telco CI lab we share vm resources between IPI and Assisted installs. When assisted installer runs we tear down the VM's that were possibly created by the IPI install and vice versa. The problem is crucible forces us to use the cluster name prepended to the vm's and this doesn't match what is used in the IPI installs.

Can I ask what the reason is for forcing the VM's names to be pre-pended by the cluster name?

nocturnalastro commented 1 year ago

The reason was to prevent name collisions when using crucible to deploy multiple clusters on to the same host. I would like to keep this behaviour, in case people are relying on it without explicitly knowing it. Perhaps we could add a flag, to stop this but leave it on by default.

p3ck commented 1 year ago

Updated so the default doesn't change the existing behavior.

p3ck commented 1 year ago

Test passed in bos2 CI.