search

redhat-partner-solutions / crucible

Apache License 2.0
34 stars 59 forks source link

Fix dns check for ipv6 and network connection check for nmstate #230

Closed nocturnalastro closed 1 year ago

thekad commented 1 year ago

@nocturnalastro this PR introduces a new variable vm_network_test_ip which is not mentioned anywhere else, no idea how/where it's set up, should it be set to the VM bridge? right now is undefined so crucible master is sort of broken until clarification is made

nocturnalastro commented 1 year ago

@thekad This should be provided by the user in there inventory. I'll have to figure up how to do a decent validation for this value but it requires connecting to the machine to check if the vm_host or the bastion is the same machine.

It should be something like the network gateway. The idea is to stop any vm_host network_config from taking down access to the machine. The previous implementation worked as long as the vm_host and bastion were different machines however if not, it can still confirm a network_config where there is no network connectivity.

We could try and get the value from network_config its self or use the gateway from the current connection but we need some form of lighthouse.