Closed ramperher closed 7 months ago
Thanks @nocturnalastro for the review, we'll validate now with the partner to confirm this works, then I'll merge :)
We've stopped the testing with the partner we're addressing this issue to focus on other tasks with more priority, that's why I've not run more tests and checks regarding this. But this is still ongoing, we'll resume the tests to validate this feature in the near future when agreeing that with the partner. So please, do not close/merge this PR yet, we've not forgotten about this :) thanks!
@ramperher If this is ready for merge can you squash your commits :)
@ramperher If this is ready for merge can you squash your commits :)
Hi @nocturnalastro ! Sure, I'm aware of this, but we'll still testing this change in the partner's lab, and bad thing is that we don't always have access there, so that's why it's being postponed :( We hope to make some advances in the next weeks, and when confirming the change is not affecting to the default case, we'll request the merge. Thanks for your interest!
Fair enough. I'll add need more testing tag back on then for now. :)
I'll be testing this change here in the collections repo: https://github.com/redhatci/ansible-collection-redhatci-ocp/pull/92, since it's easier for us. Then, I'll move the final code here just to have it in the crucible repo, just in case
Closing, moving in favour of https://github.com/redhatci/ansible-collection-redhatci-ocp/pull/92 in ansible-collections-redhatci-ocp repo