Closed manurodriguez closed 1 year ago
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Starting dci-check-change job.
Last changes also tested on Baremetal with dualstack in: https://www.distributed-ci.io/jobs/1c452a53-61cc-4fdf-b51a-0d0f1337c3c9/jobStates
Starting dci-check-change job.
Starting dci-check-change job.
Last CI job failed because I was testing a deployment without dualstack (no extra_*
variables), but hopefully this helped to spot an issue in this validation, despite the block has a condition to check if extra_api_vip
is defined and non-empty, and none of the tasks inside should be performed, looks like the vars in the tasks are interpreted.
vars:
- extra_api_vip: "{{ hostvars['assisted_installer']['extra_api_vip'] }}"
+ extra_api_vip: "{{ hostvars['assisted_installer']['extra_api_vip'] | default ([]) }}"
I amended the commit adding a default value. And launching new tests again
Starting dci-check-change job.
The last test validated we are not breaking deployments without dualstack, now it is pending to test a deployment with dualstack and extra VIPs.
FYI: We finally tested in a dualstack baremetal cluster with latest OCP 4.12, and we confirmed all the VIPs are there: https://www.distributed-ci.io/jobs/792daffb-5e1b-4118-b6be-99590434fce8/jobStates?sort=date
This change allows to pass extra VIPS for dualstack deployments using extra_api_vip and extra_ingress_vip variables.
Fixes: #261