add extra VIPs support for dualstack on OCP >= 4.12

[manurodriguez]

This change allows to pass extra VIPS for dualstack deployments using extra_api_vip and extra_ingress_vip variables.

Fixes: #261

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : FAILURE tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/b6cfb080-39d2-423d-9b0b-6f8544b77a8d/jobStates
• basic_example -> error: https://www.distributed-ci.io/jobs/5afd7449-1342-4d39-bda3-115966b3c684/jobStates

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/bd1bc077-abae-41f5-8ccd-ed5e63d22a62/jobStates
• basic_example -> success: https://www.distributed-ci.io/jobs/15ae467c-d60f-4541-aa62-433b6764a1d5/jobStates

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/86d3e3ab-6870-4df6-9783-43c8ff620993/jobStates
• basic_example -> success: https://www.distributed-ci.io/jobs/9bfc4ef6-3b45-42af-a9c8-21f0fbdfb34c/jobStates

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/3c6f9ac6-a6c1-499c-a298-d6bcef20cae3/jobStates
• basic_example -> success: https://www.distributed-ci.io/jobs/157be85e-b62a-41a3-8903-f8eafff08a95/jobStates

[manurodriguez]

Last changes also tested on Baremetal with dualstack in: https://www.distributed-ci.io/jobs/1c452a53-61cc-4fdf-b51a-0d0f1337c3c9/jobStates

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/ea3688ba-5177-4002-8fc1-53d9916a722e/jobStates
• basic_example -> success: https://www.distributed-ci.io/jobs/1eeefc38-b992-402b-8789-7e245a0737ec/jobStates

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : FAILURE tested on libvirt:assisted-abi
• assisted-abi -> error: https://www.distributed-ci.io/jobs/fab27d81-b1ee-4ba6-a7a4-8dca67b67b22/jobStates

[manurodriguez]

Last CI job failed because I was testing a deployment without dualstack (no extra_* variables), but hopefully this helped to spot an issue in this validation, despite the block has a condition to check if extra_api_vip is defined and non-empty, and none of the tasks inside should be performed, looks like the vars in the tasks are interpreted.

      vars:
-        extra_api_vip: "{{ hostvars['assisted_installer']['extra_api_vip'] }}"
+        extra_api_vip: "{{ hostvars['assisted_installer']['extra_api_vip'] | default ([]) }}"

I amended the commit adding a default value. And launching new tests again

[dcibot]

Starting dci-check-change job.

[dcibot]

• dci-check-change : SUCCESS tested on libvirt:assisted-abi
• assisted-abi -> success: https://www.distributed-ci.io/jobs/6aa3ad45-6681-42bf-ac83-297a1acf71f7/jobStates
• basic_example -> success: https://www.distributed-ci.io/jobs/58a0250d-c71d-4725-a1ca-03f4ec29b2e8/jobStates

[manurodriguez]

The last test validated we are not breaking deployments without dualstack, now it is pending to test a deployment with dualstack and extra VIPs.

[manurodriguez]

FYI: We finally tested in a dualstack baremetal cluster with latest OCP 4.12, and we confirmed all the VIPs are there: https://www.distributed-ci.io/jobs/792daffb-5e1b-4118-b6be-99590434fce8/jobStates?sort=date