search

redhat-partner-solutions / crucible

Apache License 2.0
34 stars 59 forks source link

Revert changes to use community.crypto collection in setup_selfsigned_cert #271

Closed ramperher closed 10 months ago

ramperher commented 10 months ago

This reverts some of the changes included in https://github.com/redhat-partner-solutions/crucible/commit/c86104c6b1b6070043c4eccb9f18993430412484

While testing Assisted deployments with DCI on a daily basis, e.g. here: https://www.distributed-ci.io/jobs/68c4cb1f-0ff6-4a76-b6f0-4c2704c78214/jobStates?sort=date, we discovered that the usage of community.crypto is affecting the jobs, since it's not available for downloading through RPM. Its usage in DCI would depend on creating a custom RPM and inject it in the project, and that's something we would like to avoid unless it's unavoidable to use community.crypto.

Then, the proposal is to revert the usage of community.crypto in setup_selfsigned_cert.

dcibot commented 10 months ago

Starting dci-check-change job.

dcibot commented 10 months ago
ramperher commented 10 months ago

Change worked! @nocturnalastro I think this can be merged, but I can't do it till having two approving reviews

nocturnalastro commented 10 months ago

@ramperher I'll merge it aldo was fine with the revert and you've reverted :)