search

redhat-performance / JetSki

Deployment Automation for OpenShift on Baremetal in Red Hat's Shared Labs
Apache License 2.0
21 stars 29 forks source link

pull-secret is double-quoted #173

Closed rvansa closed 1 year ago

rvansa commented 3 years ago

The Convert pullsecret to JSON in ansible-ipi-install/roles/set-deployment-fact/tasks.main cause the pull secret defined as

pullsecret: '{"auths": ... }'

to end up with one extra layer of quoting, failing the playbook when the pull-secret file is used on the provisioner.

github-actions[bot] commented 3 years ago

Thank you for raising this issue

smalleni commented 3 years ago

Please use pullsecret as is - without any begnning/ending quotes @rvansa and let me know how it goes

rvansa commented 3 years ago

@smalleni I have installed OCP now (disabling the conversion) but I perceive the pull-secret as an opaque string, therefore pasting it as such. Putting the JSON straight into YAML seems awkward. Maybe a check if the pullsecret is string or object would satisfy any use case.

smalleni commented 3 years ago

Ack. I think we had to make that change with something related to exporting these group_vars/all.yml as environment variables for tools like jenkins. We used to require a '' before that?

I like your idea, do you mind sending a PR?

rvansa commented 3 years ago

Created https://github.com/redhat-performance/JetSki/pull/174

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days