redhat-performance / JetSki

Deployment Automation for OpenShift on Baremetal in Red Hat's Shared Labs
Apache License 2.0
21 stars 29 forks source link

Use udev to disable public NICs on startup #245

Closed sferlin closed 2 years ago

sferlin commented 2 years ago

Description

Deployment of OCP on r650 hardware was having issues with IP assignment on the private and public interfaces, required for the lab setup. It seems that during startup RHCOS configures all interfaces using DHCP. Configuring the public NIC as unmanaged by NetworkManager later during statup does not have the desired effect. We therefore disable the public NIC with a new udev rule.

Fixes # (issue)

Type of change

Please select the appropriate options:

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist

afcollins commented 2 years ago

Great find! LGTM

rsevilla87 commented 2 years ago

Let's put this PR on hold until @sferlin verifies it doesn't affect other hardware

sferlin commented 2 years ago

Tested on Supermicro 1029U and Dell 640: All good with the patch.