redhat-performance / badfish

Vendor-agnostic tool for managing bare-metal systems via the Redfish API
https://quads.dev
GNU General Public License v3.0
93 stars 27 forks source link

[RFE] Add Network attributes modification #385

Open grafuls opened 1 year ago

grafuls commented 1 year ago

Is your feature request related to a problem? Please describe. Since idrac9 (version 5.10) OEM network attributes are available for modification via the redfish API. This would allow us to set SRIOV attribute at a per NIC level. Develop this new functionality into BF.

What System / IPMI Platform? idrac 9 (version 5.10)

Describe the Possible Solution Add a new argument to badfish in the form of --get-nic-attribute / --set-nic-attribute in a similar fashion to the already existing --get-bios-attribute / --set-bios-attribute.

Additional Info Reference: https://github.com/dell/iDRAC-Redfish-Scripting/issues/50#issuecomment-1127936527

dominikvagner commented 11 months ago

Copy of description from PR #392, which tries to solve this issue:

After extensive testing on my part and a joint investigation with @grafuls, this feature cannot be fully implemented in the current state of our lab, because of our iDRAC setup/versions. Getting a list of attributes for specific NICs is working as it should along with getting information about a specific attribute. (The same way as we do it for BIOS attributes.) Setting attributes though does not work, even if the somewhat incomplete feeling iDRAC documentation about this use case says it should for versions 5.x.x.x (testing was done against 5.10.50.0 as the newest version available to us). Neither my attempt at solving this or the reference script from Dell works. In our case the end-point accepting the setting of attributes shows no supported attributes to set.

The getting functionality was implemented and tested. The setting of attributes was made as a draft implementation supposed to completed in the future, when the environment will allow for it.