search

redhat-performance / benchmark-runner

Containerized Python based Framework for running and visualizing benchmark workloads on any Kubernetes/ OpenShift and runtime kinds pods, kata containers and kubevirt virtual machines simply and safely
Apache License 2.0
20 stars 19 forks source link

Update oc to cli #752

Closed ebattat closed 11 months ago

ebattat commented 12 months ago

Type of change

Note: Fill x in []

Description

Update oc to cli

For security reasons, all pull requests need to be approved first before running any automated CI

ebattat commented 11 months ago

@RobertKrawitz,

This change is relevant only OC class and not to Operator class because the operators are relevant only to OCP and not k8s, I just change all the oc methods to use the same approach.

RobertKrawitz commented 11 months ago

Those others all use the OC class though; you might as well fix it all while you're at it.

ebattat commented 11 months ago

There is no need to change all other 'oc' commands because 'csv,' 'kata,' and 'odf' are only relevant to OpenShift. This means there is no need to use 'kubectl' commands instead of 'oc'.

ebattat commented 11 months ago

@RobertKrawitz, We don't need it for OpenShift operators; we only use the 'oc' command for them

RobertKrawitz commented 11 months ago

@RobertKrawitz, We don't need it for OpenShift operators; we only use the 'oc' command for them

Yeah, OK, I'd prefer to keep it general, but I see the point.