VM memory distribution prometheus metrics

redhat-performance / benchmark-runner

Containerized Python based Framework for running and visualizing benchmark workloads on any Kubernetes/ OpenShift and runtime kinds pods, kata containers and kubevirt virtual machines simply and safely

Apache License 2.0

20 stars 19 forks source link

VM memory distribution prometheus metrics #756

Closed ebattat closed 10 months ago

ebattat commented 10 months ago

Type of change

Note: Fill x in []

[ ] bug
[x] enhancement
[ ] documentation
[ ] dependencies

Description

Add Prometheus VM memory metrics capturing:

virt-handler
virt-operator
virt-controller
virt-api

Also adding exceeds requested memory for each metric.

For security reasons, all pull requests need to be approved first before running any automated CI

bbenshab commented 10 months ago

I don't think we need to show any of those metrics in the Grafana, it's just TMI , however, we should save that data in the artifact in case we might need it for debugging.

ebattat commented 10 months ago

@bbenshab, Agree that the reason I didnt add it to the Grafana dashboard

RobertKrawitz commented 10 months ago

Good call, both adding it for debugging and not putting it in the dashboard. I think we should be reasonably free about putting metrics data in the artifact blob.