redhat-performance / benchmark-runner

Containerized Python based Framework for running and visualizing benchmark workloads on any Kubernetes/ OpenShift and runtime kinds pods, kata containers and kubevirt virtual machines simply and safely
Apache License 2.0
20 stars 19 forks source link

Update benchmark-operator to 1.0.3 #793

Closed ebattat closed 8 months ago

ebattat commented 8 months ago

Type of change

Note: Fill x in []

Description

Benchmark-operator workloads [uperf, vdbench] failed in OCP/CNV 4.15 Based on benchmark-operator PR

Root cause:

  File "/usr/local/lib/python3.8/site-packages/openshift/dynamic/discovery.py", line 193, in get_resources_for_api_version
    resource, name = subresource['name'].split('/')
ValueError: too many values to unpack (expected 2)
fatal: [localhost]: FAILED! => {
    "changed": false,
    "module_stderr": "Traceback (most recent call last):\n  File \"/opt/ansible/.ansible/tmp/ansible-tmp-1709981190.321196-648-

This looks like the same issue: https://giters.com/openshift/openshift-restclient-python/issues/437 and there is a PR, but I am not sure how to get the update, does it maybe mean this needs to be bumped? https://github.com/redhat-performance/benchmark-runner/blob/main/requirements.txt#L11 GitersGiters get_resources_for_api_version() expects sub-resource names to be of the format a/b get_resources_for_api_version() in https://github.com/openshift/openshift-restclient-python/blob/master/openshift/dynamic/discovery.py#L133, currently expects sub-resource names to be of the format a/b.

For security reasons, all pull requests need to be approved first before running any automated CI