search

redhat-performance / benchmark-runner

Containerized Python based Framework for running and visualizing benchmark workloads on any Kubernetes/ OpenShift and runtime kinds pods, kata containers and kubevirt virtual machines simply and safely
Apache License 2.0
20 stars 19 forks source link

Paramiko > 3.4.1 cause to SSH session not active #905

Closed ebattat closed 1 month ago

ebattat commented 1 month ago

Type of change

Note: Fill x in []

Description

Paramiko 3.4.0 causes the following warning: /root/benchmark-runner/venv/lib/python3.12/site-packages/paramiko/pkey.py:100: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.

After upgrading to Paramiko 3.4.1/3.5.0, the following error occurs when running a remote shell: Got SSH session not active

When revert back to paramiko==3.4.0 all working properly.

Currently, I am using filterwarnings to temporarily suppress the warning and adding a TODO to follow up on the Paramiko fix.

For security reasons, all pull requests need to be approved first before running any automated CI

RobertKrawitz commented 1 month ago

I suspect that you're using an old ssh key based on an outdated algorithm. You should update the key.

ebattat commented 1 month ago

@RobertKrawitz, Our Test env was down for 2 weeks due to this issue. After revert paramiko from 3.4.1 -> 3.4.0 issue was solved Installation passed successfully Do you think we should open an issue in paramiko project regarding it ?

RobertKrawitz commented 1 month ago

You can try, but I suspect that the issue is that the ssh key you're using relies on an outdated algorithm and that it's behaving as intended. Are you using a fixed ssh key from somewhere?

ebattat commented 1 month ago

@RobertKrawitz, Issue was solved when revert back to paramiko 3.4.0

paramiko 3.4.1/3.5.0 issue

Open paramiko issue