redhat-performance / benchmark-runner

Containerized Python based Framework for running and visualizing benchmark workloads on any Kubernetes/ OpenShift and runtime kinds pods, kata containers and kubevirt virtual machines simply and safely
Apache License 2.0
20 stars 19 forks source link

Check the VM status using virtctl instead of the SSH protocol #916

Closed ebattat closed 1 month ago

ebattat commented 1 month ago

Type of change

Note: Fill x in []

Description

Change the VM login method from SSH protocol to Virtctl, as this will provide clearer error messages. Additionally, Since the VM could be in the middle of a migration, add a retry mechanism that makes 5 attempts with a 10-second pause between each retry.

For security reasons, all pull requests need to be approved first before running any automated CI

ebattat commented 1 month ago

@RobertKrawitz, Any more comments ?