search

redhat-performance / odf-grafana

Playbook and dashboards to help with ODF performance analysis
GNU General Public License v3.0
5 stars 11 forks source link

Update ServiceAccount Role Binding for OCP 4.12 #13

Closed kdvalin closed 1 year ago

kdvalin commented 1 year ago

This PR updates the way the service account token secret is found, since OCP 4.12 removed tokens from a serviceaccount's JSON.

This closes #12

pcuzner commented 1 year ago

Hi Keith, so oc get clusterrole doesn't list the cluster-monitoring-view?

In any case, I don't think switching to the prometheus-k8s role will work in the context of ROSA which has user monitoring which requires us to go through the querier to pick up metrics from all connected user prometheus instances. Can you try you patch with the thanos-querier role?

kdvalin commented 1 year ago

Done, it's using thanos-querier now.

New thing I ran into: service accounts don't associate the token secrets with the account.. weird..

kdvalin commented 1 year ago

and running this on an OCP 4.11 cluster breaks it... yay

kdvalin commented 1 year ago

@pcuzner This one works on OCP 4.12, and I have verified the token fetching on OCP 4.11, so it should be good to merge.

LMK if you want me to squash the commits