redhat-performance / quads

:calendar: The infrastructure deployment time machine
https://quads.dev
GNU General Public License v3.0
88 stars 36 forks source link

[BUG] quads-web js assets referring to 404 images #553

Closed sadsfae closed 1 day ago

sadsfae commented 1 week ago

We seem to be trying to load assets from the following non-existent sources:

$QUADSURL/DataTables-1.10.22/images/sort_both.png
$QUADSURL/DataTables-1.10.22/images/sort_asc.png
$QUADSURL/DataTables-1.10.22/images/sort_asc_disabled.png

This results in a slow initial loading time for quads-web and the /available rendering, you can see this error in the f12 developer console window:

Failed to load resource: the server responded with a status of 404 (NOT FOUND)
Failed to load resource: the server responded with a status of 404 (NOT FOUND)

Screenshot_2024-11-19_08-17-57

We either need to remove references for this or utilize a relative path for them once we copy them locally into the repository assets to be served:

https://cdn.datatables.net/1.10.22/images/sort_both.png https://cdn.datatables.net/1.10.22/images/sort_asc.png https://cdn.datatables.net/1.10.22/images/sort_asc_disabled.png

From what I can see datatables is MIT-licensed and has no restrictions including in the repository:

https://memgraph.com/blog/what-is-mit-license#:~:text=Yes%2C%20the%20MIT%20License%20is,other%20licenses%2C%20including%20the%20GPL.

sadsfae commented 1 week ago

Perhaps related somewhat: https://github.com/redhat-performance/quads/commit/f8f7cd6806a0e1e20e6d255eb63c6e3e327d339a I think we want to still serve these two files locally and only rely on external / third party files when absolutely necessary which in the case of the relatively simple design of /available rendering isn't needed.