Use default disable-telemetry.yaml

[smalleni]

This commit removes the custom disable-notifications.yaml and removes the necessity for changes in the roles_data.yaml to disable telemetry. This is better because:

1. Using default file provided on undercloud instead of writing custom
2. No need to set notification driver per service, this file sets it to noop across all services
3. The roles_data changes are also within this default file which is maintained asa part of tripleo-heat-templates package, so less user error when making roles.

[akrzos]

@smalleni Thanks for the contribution, using the default templates for a future deployment would be preferred but I think we need to hold back on merging this for OSP11 as of right now. I am unsure if it really produces the same deployment (does this template really disable the notifications per the template on our UC it is not clear to me when compared to an OSP13 version of the same template so I would have to run a test to verify if it does or does not) and it might re-enable an issue we have seen in the past (- OS::TripleO::Services::ManilaBackendGeneric - https://github.com/redhat-performance/openstack-templates/pull/41 )

OSP11 (/usr/share/openstack-tripleo-heat-templates/environments/disable-telemetry.yaml) Contents:

# This heat environment can be used to disable all of the telemetry services.
# It is most useful in a resource constrained environment or one in which
# telemetry is not needed.

resource_registry:
  OS::TripleO::Services::CeilometerApi: OS::Heat::None
  OS::TripleO::Services::CeilometerCollector: OS::Heat::None
  OS::TripleO::Services::CeilometerExpirer: OS::Heat::None
  OS::TripleO::Services::CeilometerAgentCentral: OS::Heat::None
  OS::TripleO::Services::CeilometerAgentNotification: OS::Heat::None
  OS::TripleO::Services::CeilometerAgentIpmi: OS::Heat::None
  OS::TripleO::Services::ComputeCeilometerAgent: OS::Heat::None
  OS::TripleO::Services::GnocchiApi: OS::Heat::None
  OS::TripleO::Services::GnocchiMetricd: OS::Heat::None
  OS::TripleO::Services::GnocchiStatsd: OS::Heat::None
  OS::TripleO::Services::AodhApi: OS::Heat::None
  OS::TripleO::Services::AodhEvaluator: OS::Heat::None
  OS::TripleO::Services::AodhNotifier: OS::Heat::None
  OS::TripleO::Services::AodhListener: OS::Heat::None
  OS::TripleO::Services::PankoApi: OS::Heat::None

OSP13 contents:

# This heat environment can be used to disable all of the telemetry services.
# It is most useful in a resource constrained environment or one in which
# telemetry is not needed.

resource_registry:
  OS::TripleO::Services::CeilometerAgentCentral: OS::Heat::None
  OS::TripleO::Services::CeilometerAgentNotification: OS::Heat::None
  OS::TripleO::Services::CeilometerAgentIpmi: OS::Heat::None
  OS::TripleO::Services::ComputeCeilometerAgent: OS::Heat::None
  OS::TripleO::Services::GnocchiApi: OS::Heat::None
  OS::TripleO::Services::GnocchiMetricd: OS::Heat::None
  OS::TripleO::Services::GnocchiStatsd: OS::Heat::None
  OS::TripleO::Services::AodhApi: OS::Heat::None
  OS::TripleO::Services::AodhEvaluator: OS::Heat::None
  OS::TripleO::Services::AodhNotifier: OS::Heat::None
  OS::TripleO::Services::AodhListener: OS::Heat::None
  OS::TripleO::Services::PankoApi: OS::Heat::None

parameter_defaults:
  NotificationDriver: 'noop'

[smalleni]

Got it. Makes sense.