search

redhat-performance / tuned

Tuning Profile Delivery Mechanism for Linux
GNU General Public License v2.0
755 stars 171 forks source link

Be explicit about amd-pstate support #572

Closed zacikpa closed 7 months ago

zacikpa commented 7 months ago

Since intel_pstate and amd-pstate use the same per-CPU interface for setting EPP hints, the current cpu plugin supports amd-pstate out of the box.

This commit modifies current P-state related logs and variable names to be explicit about the support for amd-pstate.

Note that while intel_pstate supports global attributes such as max_perf_pct, amd-pstate does not.

yarda commented 7 months ago

Please add Jira ticket reference to the commit message.

zacikpa commented 7 months ago

Right, forgot about that. Fixed.

yarda commented 7 months ago

Thanks, LGTM.

Personally, I don't like that the Intel driver is called intelpstate, but the AMD driver is called amd-pstate (i.e. "" vs "-"). It seems this inconsistency is in the kernel sources and even the registered cpufreq driver names are inconsistent, so let's follow the kernel.