search

redhat-performance / tuned

Tuning Profile Delivery Mechanism for Linux
GNU General Public License v2.0
755 stars 171 forks source link

Add missing install command for tuned-ppd.py #598

Closed superm1 closed 5 months ago

superm1 commented 5 months ago

Fixes: 3e03b8b Configure the PPD-to-TuneD daemon to work as a replacement of PPD Signed-off-by: Mario Limonciello mario.limonciello@amd.com Closes: https://github.com/redhat-performance/tuned/issues/597

yarda commented 5 months ago

Thanks, LGTM. It seems it was missed during review and by CI. Unfortunately, we don't deploy releases this way for some time, so nobody noticed :).

superm1 commented 5 months ago

FYI There is a secondary problem too, but it should probably be a different PR. This one I'm less sure about, but maybe it jumps out to you :)

+ CXX=g++
+ export CXX
+ cd tuned-2.21.0
+ make test PYTHON=/usr/bin/python3
make[1]: Entering directory '/home/supermario/rpmbuild/BUILD/tuned-2.21.0'
/usr/bin/python3 -B -m unittest discover tests/unit
.............................................................................................................
----------------------------------------------------------------------
Ran 109 tests in 0.054s

OK
make[1]: Leaving directory '/home/supermario/rpmbuild/BUILD/tuned-2.21.0'
+ RPM_EC=0
++ jobs -p
+ exit 0
Processing files: tuned-2.21.0-1.fc39.noarch
error: File must begin with "/": %{python3_sitelib}/tuned/gtk
error: File must begin with "/": %{python3_sitelib}/tuned

RPM build errors:
    File must begin with "/": %{python3_sitelib}/tuned/gtk
    File must begin with "/": %{python3_sitelib}/tuned
make: *** [Makefile:85: rpm] Error 1
superm1 commented 5 months ago

FYI There is a secondary problem too, but it should probably be a different PR. This one I'm less sure about, but maybe it jumps out to you :)

FWIW I was missing python3-devel. I guess it didn't check for that when I built.

yarda commented 5 months ago

FYI There is a secondary problem too, but it should probably be a different PR. This one I'm less sure about, but maybe it jumps out to you :)

FWIW I was missing python3-devel. I guess it didn't check for that when I built.

There are currently no checks for the installed packages in the Makefile. It's usually not done in Makefiles, you need to satisfy the deps yourself. The tuned.spec file can be good source of information. For autodetection we would have to switch to Autotools or different higher level build system.