search

redhat-qe-security / SCAutolib

Library for automation of smart card testing
GNU General Public License v3.0
3 stars 10 forks source link

Marek notes #41

Closed mahavrila closed 2 years ago

mahavrila commented 2 years ago

This are my notes about a code I wrote down last week. It may be a bit chaotic... We may consider to make some changes based on this notes or we can just wait for refactoring and ignore it...

  1. general setup:

    • only 'check semodule' and install missing packages
    • check semodule is called only in general setup
    • does it mean it is only necessary for package installation? This makes me ask - what should and should not be in 'general setup'? Why is for example 'create_sssd_config' standalone?

  2. setup_virtcacard:

    • local user is created here (an it is not logical)
    • we need to setup card to create local user
    • addition of local user should be standalone/separate function (similarly to addition of IPA user) for the clarity of code

  3. create_softhsm2_config:

    • is called in 'create_sc' twice:
      • A) separately
      • B) as part of setup_virtcacard
      • ...and setup_virtcacard is called only in create_sc so call of create_softhsm2_config can be removed either from A) or B)
x00Pavel commented 2 years ago

This notes would be considered in new architecture of the library

x00Pavel commented 2 years ago

It will be fixed in new versions